Skip to content

fix: remove type:/platform: prefixes from PR classification labels #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yanas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove type:/platform: prefixes from PR classification labels #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/pr-classify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,11 @@ jobs:
const validPlatforms = ['web', 'android', 'ios', 'native'];

if (validTypes.includes(parsed.type)) {
typeLabel = `type: ${parsed.type}`;
typeLabel = parsed.type;
}
if (Array.isArray(parsed.platforms)) {
platformLabels = parsed.platforms
.filter(p => validPlatforms.includes(p))
.map(p => `platform: ${p}`);
.filter(p => validPlatforms.includes(p));
}
summary = parsed.summary || null;
}
Expand All @@ -108,10 +107,12 @@ jobs:
}
}

// --- Remove old type:/platform: labels ---
// --- Remove old type/platform labels ---
const validTypes = ['feature', 'fix', 'chore', 'refactor', 'language', 'documentation', 'test', 'security'];
const validPlatforms = ['web', 'android', 'ios', 'native'];
const existingLabels = await github.rest.issues.listLabelsOnIssue({ owner, repo, issue_number });
const toRemove = existingLabels.data
.filter(l => l.name.startsWith('type: ') || l.name.startsWith('platform: '))
.filter(l => validTypes.includes(l.name) || validPlatforms.includes(l.name))
.map(l => l.name);

for (const label of toRemove) {
Expand All @@ -132,7 +133,7 @@ jobs:
if (parseError || !typeLabel) {
await github.rest.issues.createComment({
owner, repo, issue_number,
body: `> [!WARNING]\n> **PR classification** could not determine the PR type. Please apply a \`type:\` label manually.`
body: `> [!WARNING]\n> **PR classification** could not determine the PR type. Please apply a type label manually.`
});
} else if (summary) {
const platformStr = platformLabels.length > 0
Expand Down
Loading