Add ability to log timings of some events...#248
Draft
Conversation
added 2 commits
February 11, 2026 11:22
… different downtimes)
secwall
reviewed
Feb 11, 2026
Contributor
secwall
left a comment
secwall
left a comment
There was a problem hiding this comment.
I also think that we need to add tests on this.
| go r.send(eventType, duration) | ||
| } | ||
|
|
||
| func (r *timingReporter) send(eventType string, duration time.Duration) { |
Contributor
There was a problem hiding this comment.
This approach leads to unlimited number of simultaneously running commands. Shouldn't we try a different approach? Like running a goroutine that reads a buffered channel of events and runs a single command to send them one by one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configurable support for logging different timings via calling of external tool.
Currently are supported following events: