[4-mom] Small improvements to 4-momenta calculation#141
Open
pdigiglio wants to merge 1 commit intoyap:masterfrom
Open
[4-mom] Small improvements to 4-momenta calculation#141pdigiglio wants to merge 1 commit intoyap:masterfrom
pdigiglio wants to merge 1 commit intoyap:masterfrom
Conversation
pdigiglio
commented
Mar 12, 2017
src/FourMomenta.cxx
Outdated
| pp[i][j] = pow(initial_mass, 2) + (n_fsp - 2.) * m2_sum_1 - m2_sum_2; | ||
| for (unsigned i = 0; i < n_fsp; ++i) { | ||
| // Find element that are smaller than zero in the upper triangle of the matrix. | ||
| const auto it = std::find_if(std::begin(pp[i]) + i + 1, std::end(pp[i]), |
Contributor
Author
There was a problem hiding this comment.
This is actually wrong. It will only assign to the first negative element for each value of i. Still, all the tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I slightly simplified the
calculate_four_momenta()function. I think it's easier to read and (probably) faster now.