remove owner from mass shape so that it can be shared#143
Open
Jojosito wants to merge 1 commit intoyap:masterfrom
Open
remove owner from mass shape so that it can be shared#143Jojosito wants to merge 1 commit intoyap:masterfrom
Jojosito wants to merge 1 commit intoyap:masterfrom
Conversation
greenwald
requested changes
Jun 6, 2017
Contributor
greenwald
left a comment
greenwald
left a comment
There was a problem hiding this comment.
We should be able to get the DecayingParticle (or Model, whichever it is we need) from the DecayChannel without having to explicitly pass it through the constructor. And the MassShape should now have it's own RadialSize, if it is not bound to a single DecayingParticle. We should create functions to easily share parameters, such as RadialSize, between different particles and between particles and mass shapes.
Contributor
Author
|
I guess we could get rid of addDecayChannel (which is implemented only for RelativisticBreitWigner, and doesn't even use the DecayChannel). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.