Conversation
| let bashrc_content = tmp_dir | ||
| .with_join_str(".bashrc") | ||
| .fs_read_text_prealloc() | ||
| .expect("Failed to read .profile"); | ||
| .expect("Failed to read .bashrc"); | ||
|
|
||
| assert_eq!(profile_content, format!(". \"{}/.yarn/switch/env\"\n", tmp_dir.to_file_string())); | ||
| assert_eq!(bashrc_content, format!("# Added by Yarn Switch\nsource \"{}/.yarn/switch/env\"\n", tmp_dir.to_file_string())); |
There was a problem hiding this comment.
Those changes don't seem related
There was a problem hiding this comment.
These are in a separate commit, these tests failed and now they no longer do. I can split this out into a separate pr if you prefer.
Won't be until Thursday evening though, won't have any time to spare before then.
bgotink
force-pushed
the
bgotink/switch-from-npm
branch
from
b16a656 to
b884681
Compare
bgotink
force-pushed
the
bgotink/switch-from-npm
branch
from
b884681 to
e452826
Compare
⏱️ Benchmark Resultsgatsby install-full-cold
📊 Raw benchmark data (gatsby install-full-cold)Base times: 4.528s, 4.430s, 4.496s, 4.532s, 4.442s, 4.335s, 4.484s, 4.433s, 4.435s, 4.414s, 4.422s, 4.437s, 4.452s, 4.451s, 4.502s, 4.454s, 4.433s, 4.645s, 4.519s, 4.497s, 4.446s, 4.479s, 4.494s, 4.429s, 4.457s, 4.471s, 4.461s, 4.433s, 4.442s, 4.411s Head times: 4.504s, 4.495s, 4.474s, 4.472s, 4.461s, 4.390s, 4.430s, 4.401s, 4.377s, 4.559s, 4.432s, 4.452s, 4.392s, 4.475s, 4.436s, 4.461s, 4.572s, 4.559s, 4.474s, 4.541s, 4.470s, 4.577s, 4.572s, 4.630s, 4.468s, 4.484s, 4.456s, 4.507s, 4.490s, 4.527s gatsby install-cache-only
📊 Raw benchmark data (gatsby install-cache-only)Base times: 1.268s, 1.267s, 1.272s, 1.278s, 1.283s, 1.277s, 1.284s, 1.292s, 1.279s, 1.265s, 1.265s, 1.277s, 1.256s, 1.275s, 1.231s, 1.244s, 1.246s, 1.230s, 1.241s, 1.233s, 1.251s, 1.249s, 1.252s, 1.257s, 1.269s, 1.290s, 1.282s, 1.273s, 1.304s, 1.273s Head times: 1.276s, 1.269s, 1.270s, 1.298s, 1.273s, 1.279s, 1.281s, 1.271s, 1.282s, 1.259s, 1.275s, 1.259s, 1.271s, 1.306s, 1.280s, 1.273s, 1.276s, 1.285s, 1.293s, 1.251s, 1.253s, 1.233s, 1.232s, 1.245s, 1.268s, 1.263s, 1.273s, 1.253s, 1.257s, 1.255s gatsby install-cache-and-lock (warm, with lockfile)
📊 Raw benchmark data (gatsby install-cache-and-lock (warm, with lockfile))Base times: 0.344s, 0.330s, 0.336s, 0.332s, 0.352s, 0.333s, 0.339s, 0.336s, 0.341s, 0.335s, 0.335s, 0.337s, 0.334s, 0.330s, 0.333s, 0.334s, 0.332s, 0.341s, 0.332s, 0.331s, 0.331s, 0.332s, 0.333s, 0.332s, 0.334s, 0.332s, 0.335s, 0.339s, 0.335s, 0.339s Head times: 0.329s, 0.332s, 0.329s, 0.332s, 0.336s, 0.331s, 0.327s, 0.329s, 0.327s, 0.331s, 0.336s, 0.342s, 0.341s, 0.328s, 0.330s, 0.332s, 0.330s, 0.329s, 0.331s, 0.333s, 0.333s, 0.330s, 0.327s, 0.329s, 0.329s, 0.331s, 0.334s, 0.336s, 0.332s, 0.331s |
2 participants
Closes #287