Fix panic when using ed25519 with a key that is not 64 bytes long#15
Merged
yaronf merged 1 commit intoyaronf:mainfrom Jul 23, 2025
Merged
Fix panic when using ed25519 with a key that is not 64 bytes long#15yaronf merged 1 commit intoyaronf:mainfrom
yaronf merged 1 commit intoyaronf:mainfrom
Conversation
yaronf
added a commit
that referenced
this pull request
Mar 13, 2026
…age error - crypto.go: replace unguarded type assertions in sign() and verify() with safe comma-ok assertions returning "malformed key" to prevent panic on misuse - digest.go: replace bytes.Equal with subtle.ConstantTimeCompare for Content-Digest validation - httpparse.go: parseMessage(nil) now returns an error instead of (nil, nil) to prevent silent failures in callers Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @yaronf,
This PR avoids a panic caused by an incorrectly sized ed25519 key.
Hope it helps, and thanks for building this awesome library!