add expiresAfter to use a relative delay for expires#18
Merged
yaronf merged 3 commits intoyaronf:mainfrom Mar 17, 2026
Merged
Conversation
2b3f6e2 to
7c2cb79
Compare
Owner
|
Looks good. Two comments (thanks Cursor...)
|
Test that expiresAfter correctly computes expires as created + delay, that setting both SetExpires and SetExpiresAfter returns an error, and that the handler rejects expired signatures using SetExpiresAfter.
69d90ce to
9f23d36
Compare
Contributor
Author
|
Thanks for the review and for your patience. I just updated my PR. |
Owner
|
Looks good, thanks for your contribution. I will follow up with a minor fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
First, thank you very much for the lib!
While using the wrap handler, I found useful to have way to configure a relative expiration delay instead of configuring an absolute one.