Made broadcast option available via PHP#4
Open
mrwhale wants to merge 1 commit intoyasharrashedi:masterfrom
Open
Made broadcast option available via PHP#4mrwhale wants to merge 1 commit intoyasharrashedi:masterfrom
mrwhale wants to merge 1 commit intoyasharrashedi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added in broadcast option. just needed to set socket_option in the send command function
This enabled PHP to send to broadcast address, but also still works when specifying specific address
Also added function so when you don't specify an IP in milight constructor it will automatically create it using the broadcast address for the LAN
$milight = new Milight();Known issues- Unable determine subnet mask of server with PHP, so this function will assume everyone is on a /24 subnet
relates to issue #3