Allow to use ydbd built from current source ( -DUSE_BUNDLED_YDBD=1 )#5537
Allow to use ydbd built from current source ( -DUSE_BUNDLED_YDBD=1 )#5537proller wants to merge 1 commit intoydb-platform:mainfrom
Conversation
|
Note This is an automated comment that will be appended during run. 🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 244s): all tests PASSED for commit 258d9e1.
🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 222s): all tests PASSED for commit 258d9e1.
🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1385s): all tests PASSED for commit 258d9e1.
🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 4598s): all tests PASSED for commit 258d9e1.
|
| SRCDIR( | ||
| contrib/ydb/apps/ydbd | ||
| ) |
There was a problem hiding this comment.
We try to avoid patching YDB code directly. Have you considered submitting a PR to YDB?
| @@ -1,10 +1,14 @@ | |||
| PACKAGE() | |||
| IF(USE_BUNDLED_YDBD) | |||
| INCLUDE(${ARCADIA_ROOT}/contrib/ydb/apps/ydbd/ya.make) | |||
There was a problem hiding this comment.
Why do we need this?
Maybe it would be better for the package to depend directly on YDB sources instead of using cloud/storage/core/tools/testing/ydb/bin with USE_BUNDLED_YDBD=1?
There was a problem hiding this comment.
OK, we need it on ARM in order to make already existing targets that depend on cloud/storage/core/tools/testing/ydb/bin to build ydbd from sources instead of using prebuilt binary
2 participants
Notes
Describe your PR - what it does and why this needs to be done.
Issue
Put links to the related issues here