issue-4875: Fix data loss on fresh blobs data loading with Fresh Blocks Writer Feature#5567
Open
vladstepanyuk wants to merge 1 commit intomainfrom
Open
Conversation
Contributor
|
Note This is an automated comment that will be appended during run. 🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 246s): all tests PASSED for commit 73bdaf5.
🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 222s): all tests PASSED for commit 73bdaf5.
🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1474s): all tests PASSED for commit 73bdaf5.
🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 4729s): all tests PASSED for commit 73bdaf5.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
We persist the current TrimFreshLogToCommitId for every AddBlobs transaction in the local database. On partition start, we load all the blobs starting from that persisted TrimFreshLogCommitId. So, if at the time of AddBlob transaction execution, there are some inflight requests with a commit id less than the TrimFreshLog to CommitId in the partition and a reboot occurs after the transaction completes, we will not load fresh blobs with a commit id less than the TrimFreshLog from the FBW , though response was already sent.
In this PR i persist Last TrimFreshLogToCommitId, which takes into account commits from FBW
Issue
#4875