Open
Conversation
3e73b7b to
b80efe3
Compare
Contributor
|
Note This is an automated comment that will be appended during run. 🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 225s): all tests PASSED for commit b80efe3.
🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 432s): all tests PASSED for commit b80efe3.
🔴 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1545s): some tests FAILED for commit b80efe3.
🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 44s): all tests PASSED for commit b80efe3.
🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 4793s): all tests PASSED for commit b80efe3.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5095
Register()no longer consumes budget in a single fixed way for the gap between the minimum and maximum budget spend. It now picks a desired spend by interpolating betweenminBudgetSpendandmaxBudgetSpendusing Smootherstep(CurrentBudget / MaxBudget). Consumption should be higher when the budget is fuller.For interpolation i chose the smootherstep. It is slightly faster than sigmoid and simpler to use, as it is conveniently positioned relative to the y-axis (unlike sigmoid).
Added a benchmark that compares sigmoid to smoothstep functions. Results are: