Support YDB view reflection#111
Merged
Merged
Conversation
vgvoleg
force-pushed
the
issue-110-view-reflection
branch
from
abe7178 to
c29f7f0
Compare
LuckySting
suggested changes
May 18, 2026
Comment on lines
+266
to
+267
| if schema: | ||
| raise ydb_dbapi.NotSupportedError("unsupported on non empty schema") |
Contributor
There was a problem hiding this comment.
suggestion (non-blocking): Move this to a private helper method, and call in all methods.
Comment on lines
+71
to
+76
| finally: | ||
| try: | ||
| cursor.execute_scheme(f"DROP VIEW `{view_name}`") | ||
| except Exception: | ||
| pass | ||
| cursor.close() |
Contributor
There was a problem hiding this comment.
suggestion (non-blocking): Move Try and Except part with creation of the view to a yield fixture.
| type_name = type_name[:-1] | ||
|
|
||
| decimal_match = DECIMAL_DBAPI_TYPE_RE.match(type_name) | ||
| if decimal_match: |
Contributor
There was a problem hiding this comment.
question: What about Array and other container types? They could be in View columns, don't they?
Member
Author
There was a problem hiding this comment.
the problem is same for tables, let's fix this outside of this pr
vgvoleg
force-pushed
the
issue-110-view-reflection
branch
from
c29f7f0 to
c567a79
Compare
LuckySting
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #110