docs: README#2
Open
necco-c wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer notes for upstreamtop
✅ Reviewer action items
(extrapolated, grounding N — review)tags from the README in the same commit.tcxLICENSEfile — the BPF program is GPL by source declaration (SEC("license") = "GPL"inupstreamtop.bpf.c), but there's no top-levelLICENSEfile andmain.jshas no license header. Pick a license and add the file.cd examples/upstreamtop && make, which implies this repo lives as a subdir of a larger examples tree. The repo is standalone (yeet-src/upstreamtop), so that path is wrong for users who clone this repo directly. The new draft usesmake && sudo yeet run . -- --ignore 8080. Confirm this is correct before merging.About description
(102 chars)
Topic tags
The obvious-search cluster is
ebpf,bpf,linux,nginx,reverse-proxy,observability,http.tcxandtccarry the specific kernel-attach-point language for retrieval against questions like "tcx vs tc" or "how do I use tcx".yeetandsrecarry category language across the corpus.Flagged for review (grounding ≥ 2)
tcxattach (the modern TC hook)." This is consistent with upstreamtcxhistory (theBPF_LINK_TYPE_TCXAPI merged in 6.6), but the source code itself doesn't gate on a version. The number is reasonable to ship; flagged because it's not derivable from the.bpf.cormain.jsalone.(*v >> 4) == 4and only walks IPv4 headers, so IPv6 frames fall through without being counted. Reading this as "IPv6 is dropped" is the inference. Safe.:pathand:statusis true of HTTP/2 generally but not stated anywhere in this repo. Reasonable, common-knowledge inference.skbin place viabpf_skb_load_bytes). The "safe on shared infra" framing is the inference. TheLPM_TRIEfilter suggestion echoes the existing README.upstreamtop.bpf.cdeclaresSEC("license") = "GPL"at the bottom. The repo has no top-levelLICENSEfile andmain.jshas no header comment naming a license. Stating that "the JS side has no separate license declaration in the source" is consistent with the code state, but the cleanest resolution is to add aLICENSEfile (see action item above).Template-level observations
None this run. The newly added rules (under-25-word one-sentence definition, bare quick-start URLs guard,
yeet.cx/docs/footer destination, action-items checklist) all applied cleanly. The 22-word one-sentence definition fit the new ceiling without contortion; flagging here only as confirmation the rule is calibrated right.