Multisig - Add new test-cases for fund transfer Tx#2
Closed
githubckgoh1439 wants to merge 4 commits into
Closed
Conversation
Author
|
Create-multisig-Tx - Issue on Re-submit using unique nonce, TxID Hi, YK Found some abnormal situations base on above cases Attached with the examples of DB state query : [postman-sample-1]_get_multisig_acc.txt Please check and update. TQ. |
Owner
|
how many internal transaction u created? |
githubckgoh1439
commented
Apr 5, 2020
| console.log("txtxtxtxxtxtxtxtxtxtx" + JSON.stringify(tx)); | ||
| if (!tx.nonce || !tx.accountNumber || !tx.value || !tx.value.msg || !Array.isArray(tx.value.msg)) { | ||
| if (!tx.nonce) { | ||
| errors.throwError('missing transaction field', errors.MISSING_ARGUMENT, { argument: 'value', value: tx }); |
Author
There was a problem hiding this comment.
Hi, YK
The debugger show the Error in here, while come to the process signed by signer-2.
Attached with the compare between signer-1 & signer-2 for their InternalTx signing.
Please check.
Author
|
Resolved the conflict in multisig.ts |
Author
|
Dear all, Pleace refer to latest of this : This pull request can be ignored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, YK
Added some test-cases for Create-multisig-tx.