Added support for sendContext#2
Open
alexjoybc wants to merge 1 commit into
Open
Conversation
Owner
|
Hi alexjoybc, |
Author
|
Just seeing this now... I will have a look next week thanks for the feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the following proposed change:
SendContextThis is more a start for a discussion, I have fork your lib and put it in one of my project.
I was something similar to sending via interface
and noticed that the
uber-trace-idwas missing in the message context:I did a quick modification to your code to accommodate this, as you can see there's some duplication as I went and copy paste most of your code (really handy btw).
Type of change
How Has This Been Tested?
I have tested this in a different project. no unit testing
Checklist: