Merged
Conversation
* LRS-30 backwards compatible but now fails both branches * LRS-30 fix alt syntax backwards compat, more issues remain * LRS-30 return a valid old version if specified * conditional version dispatch for doc etag behavior * test multiple versions * remove println * deps * bump tmp * correct sync doc handling * bump cljs * fix cljs multipart handling * bump ci java version
4 tasks
milt
commented
Oct 1, 2025
milt
commented
Oct 1, 2025
milt
commented
Oct 1, 2025
Member
Author
There was a problem hiding this comment.
there were some major errors in this file, interceptors being applied multiple times or not at all
milt
commented
Oct 1, 2025
Member
Author
There was a problem hiding this comment.
2.0.0 has weird duration normalization requirements
cliffcaseyyet
approved these changes
Oct 6, 2025
| (defn normalize-duration | ||
| "Normalize an xAPI duration string to 0.01 second precision" | ||
| [duration] | ||
| (let [duration-str (subs duration 1) ;; Remove 'P' |
Member
There was a problem hiding this comment.
I'm surprised there is not an easy lib for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LRS-30
Wherein we strive to be conformant per version "2.0" of the conformance tests:
https://github.com/adlnet/lrs-conformance-test-suite/tree/LRS-2.0
Will require a decent rework to handle both old and new versions, this branch starts that process.
Currently passes 1.0.3 AND 2.0.0 tests (on the
masterbranch) in both CLJ and CLJSAlso see: yetanalytics/xapi-schema#90 for the
xapi-schema-componentNotable Internals for implementors
LRS implementors can leverage the following features
:com.yetanalytics.lrs/versionctx value - the given (valid) client xapi version of requestTODO:
interceptor