fix: handle language dropdown in ExpandedHeader

[asanehisa]

Completely forgot this exists and wasn't being handled nicely in tablet viewport in Editor.

Untitled.mov

[github-actions]

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

[pkg-pr-new]

• pages-visual-editor-starter

  npm i https://pkg.pr.new/yext/visual-editor/@yext/visual-editor@1042
  

commit: 2778f3a

[coderabbitai]

Walkthrough

This PR modifies the visibility logic for the secondary header in the visual editor. The change removes the editing state check from the condition that determines whether the secondary header should be hidden, so the header visibility now depends solely on the overflow state when not in menu mode. The dependency array of the effect hook is updated to include the overflow state to ensure proper re-evaluation when overflow changes.

Possibly related PRs

• feat: empty secondary header state #889: Also modifies the same SecondaryHeaderSlot component and adjusts editing-aware visibility logic for the secondary header, introducing placeholder/early-return behavior in contrast to this PR's removal of the editing guard.

Suggested reviewers

• mkilpatrick
• briantstephan
• benlife5

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title mentions 'language dropdown in ExpandedHeader' but the summary shows changes to SecondaryHeaderSlot affecting overflow and editing state logic, creating ambiguity about alignment.	Clarify whether the title should reflect the secondary header overflow fix or confirm the language dropdown handling is the primary change being addressed.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description mentions a tablet viewport issue that wasn't being handled nicely in the Editor, with supporting screenshots and a video link. This clearly relates to the changeset which modifies the SecondaryHeaderSlot component to better handle responsive behavior.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch language-dropdown

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}