Skip to content

Conversation

@asanehisa
Copy link
Contributor

@asanehisa asanehisa commented Feb 11, 2026

No migration needed as the code assumes true unless set. On hide, the icons are hidden. TIAA specifically wanted this for the Professional Hero Section but added it for all Phone, PhoneList, Email slots.

Screenshot 2026-02-11 at 4 01 33 PM

@asanehisa asanehisa added the create-dev-release Triggers dev release workflow label Feb 11, 2026
@github-actions
Copy link
Contributor

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 11, 2026

commit: ba91f4c

@asanehisa asanehisa marked this pull request as ready for review February 11, 2026 21:08
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

Walkthrough

Adds icon-visibility toggles for Emails and Phone in the visual editor. Introduces a new boolean style field showIcon for Emails and includeIcon for Phone (defaults true) and updates PhoneList to respect includeIcon. Adds showIcon localization entries across platform locales. Updates component docs to include the new Emails styles field and adds a test case verifying rendering when phone and email icons are disabled.

Suggested reviewers

  • briantstephan
  • jwartofsky-yext
  • benlife5
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding show/hide functionality for email and phone icons across components.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale (no migration needed, defaults to true), scope (Phone, PhoneList, Email slots), and specific use case (TIAA's Professional Hero Section).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch icons

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@asanehisa asanehisa requested review from benlife5, briantstephan, jwartofsky-yext and mkilpatrick and removed request for benlife5 February 11, 2026 21:45
mkilpatrick
mkilpatrick previously approved these changes Feb 11, 2026
benlife5
benlife5 previously approved these changes Feb 12, 2026
@asanehisa asanehisa dismissed stale reviews from benlife5 and mkilpatrick via a305ee4 February 12, 2026 15:12
@asanehisa asanehisa requested review from benlife5 and mkilpatrick and removed request for mkilpatrick February 12, 2026 15:26
@asanehisa asanehisa merged commit 8868102 into main Feb 12, 2026
17 checks passed
@asanehisa asanehisa deleted the icons branch February 12, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-dev-release Triggers dev release workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants