Limit the number of header lines per multipart form-data part#2497
Merged
Conversation
Owner
|
@superm1 thanks for the PR. Could you please add at least one unit test? |
The multipart/form-data parser bounded the length of each individual header line via CPPHTTPLIB_HEADER_MAX_LENGTH but did not cap how many header lines a single part could contain. Within the overall payload limit, a client could pack a large number of small header lines into one part, each of which is parsed twice, inflating CPU usage. Add a per-part header-line counter that resets when a new entry begins and abort parsing once it reaches CPPHTTPLIB_HEADER_MAX_COUNT, mirroring the limit already enforced by read_headers() for request headers.
superm1
force-pushed
the
superm1/SWSPLAT-23636
branch
from
July 19, 2026 00:20
5425ce9 to
877a52f
Compare
Contributor
Author
|
Added! |
Owner
|
@superm1 thanks for this contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The multipart/form-data parser bounded the length of each individual header line via
CPPHTTPLIB_HEADER_MAX_LENGTHbut did not cap how many header lines a single part could contain. Within the overall payload limit, a client could pack a large number of small header lines into one part, each of which is parsed twice, inflating CPU usage.This adds a per-part header-line counter that resets when a new entry begins and aborts parsing once it reaches
CPPHTTPLIB_HEADER_MAX_COUNT, mirroring the limit already enforced byread_headers()for request headers.