Log res.error() on all ServerTest ASSERT_TRUE(res) assertions#2507
Merged
Conversation
Only 8 of 423 call sites logged the actual error on failure. The MbedTLS-backend flaky CI failure (connection-level ASSERT_TRUE(res), ~20-30ms) keeps landing on assertions without this diagnostic, so the real error code has never been captured. Broadens the existing GetWithRange-only logging (a4d7066) to every plain ASSERT_TRUE(res); site, no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ASSERT_TRUE(res)call sites in test.cc logged the actual error on failureASSERT_TRUE(res), ~20-30ms, tracked across GetWithRange4/5, TooLongRequest, UserDefinedMIMETypeMapping) keeps landing on assertions without this diagnostic, so the real error code has never been capturedASSERT_TRUE(res);site — no behavior change, purely diagnosticTest plan
make test_mbedtls— all 736 tests pass locallymake test_split_mbedtls— split build compiles cleanly