Draft
Conversation
Co-authored-by: M Bernt <m.bernt@ufz.de>
Co-authored-by: M Bernt <m.bernt@ufz.de>
needed because of the specifics of the Galaxy tool generator
needed because of the specifics of the Galaxy tool generator
Co-authored-by: M Bernt <m.bernt@ufz.de>
Co-authored-by: M Bernt <m.bernt@ufz.de>
- unified handling of --configFile - specify default values only in the parsing, nowhere else (but only for "train" and "predict", for the other modes, this still needs to be done) - put modes into separate files (train, predict, trainggn, predictgnn, interpretgnn, convert) - parse JSON configs just like CLI args (this will give the user feedback concerning syntax errors etc in the JSON, just like with CLI args) - removed jsonpickle dependency - removed py/object from JSON configs (not needed anymore) - removed aeOptimizer argument (wasn't being used) - added parsing for --fnnType - split train/predict Options into three classes (common, train, predict) - added todo's regarding some confusing parts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This primarily fixes the order in which values/defaults are loaded.
--configFiletrainandpredict, for the other modes, this still needs to be done)train,predict,trainggn,predictgnn,interpretgnn,convert)jsonpickledependencypy/objectfrom JSON configs (not needed anymore)aeOptimizerargument (wasn't being used)--fnnTypeI first focussed on getting
trainandpredictrunning, the other modes (trainggn,predictgnn,interpretgnn,convert) still need some work.Also, the tests (
run_*.py) need some work.I will make further commits onto this branch until this PR is ready to be merged.