fix(Antigravity): Add binaryFallbacks for antigravity parser#77
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🟡 Resume command display for Antigravity doesn't mention the alternative binary name
The resume display string only shows antigravity (resumeCommandDisplay: () => \antigravity`atsrc/parsers/registry.ts:902) even though a fallback binary agy` was added, so users who have only the shorthand installed see a command they cannot run.
Impact: Users who installed the agy alias instead of antigravity will see an incorrect manual resume command in the TUI.
Inconsistency with established Cursor binary-fallback pattern
The existing Cursor adapter at src/parsers/registry.ts:772-777 follows the convention of listing the fallback in the display string:
binaryFallbacks: ['agent'],
resumeCommandDisplay: (s) => `cursor-agent --resume ${s.id} (or: agent --resume ${s.id})`,The Antigravity adapter adds binaryFallbacks: ['agy'] at line 897 but leaves resumeCommandDisplay at line 902 unchanged as () => \antigravity`. To be consistent, it should read something like () => `antigravity (or: agy)``.
The actual binary resolution in src/utils/resume.ts:309-316 (resolveToolBinaryName) correctly iterates over both candidates, so execution will work. But the display string shown to users (used by getResumeCommand at src/utils/resume.ts:358) will only show antigravity.
(Refers to line 902)
Was this helpful? React with 👍 or 👎 to provide feedback.
| // is unset, so changes to that var must also invalidate the index cache. | ||
| extraEnvVars: ['GEMINI_CLI_HOME', 'ANTIGRAVITY_STATE_DB'], | ||
| binaryName: 'antigravity', | ||
| binaryFallbacks: ['agy'], |
There was a problem hiding this comment.
📝 Info: Binary fallback resolution works correctly for execution
While the resumeCommandDisplay inconsistency was flagged as a bug, the actual binary resolution logic in src/utils/resume.ts:309-316 (resolveToolBinaryName) iterates through all candidates from getToolBinaryCandidates (src/utils/resume.ts:27-31), which correctly includes both antigravity and agy. So the tool will functionally work for users who only have agy installed — the issue is only in the display string shown to the user.
Was this helpful? React with 👍 or 👎 to provide feedback.
| // is unset, so changes to that var must also invalidate the index cache. | ||
| extraEnvVars: ['GEMINI_CLI_HOME', 'ANTIGRAVITY_STATE_DB'], | ||
| binaryName: 'antigravity', | ||
| binaryFallbacks: ['agy'], |
There was a problem hiding this comment.
📝 Info: No test coverage for the new Antigravity binaryFallbacks
The existing test suite has a test for Cursor's binaryFallbacks at src/__tests__/forward-flags.test.ts:48 (expect(adapters.cursor.binaryFallbacks).toEqual(['agent'])), but this PR does not add an analogous test for Antigravity's new binaryFallbacks: ['agy']. REVIEW.md says 'PRs that add source files under src/ but do not touch any test files should be flagged', but this PR modifies (rather than adds) a source file, so it's a soft concern rather than a rule violation. A simple assertion like expect(adapters.antigravity.binaryFallbacks).toEqual(['agy']) would be consistent with existing patterns.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Summary
agyas a binary fallback for antigravity.Error: Tool not available: Antigravity. Is it installed and on your PATH?error.Summary by cubic
Add
agyas a binary fallback for the Antigravity parser so the CLI can detect the tool when installed under that name, fixing "Tool not available: Antigravity" PATH errors.Written for commit a9cf242. Summary will update on new commits.