chore: satisfy current Biome checks#79
Open
thekidnamedkd wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
While preparing the OMP integration, I noticed the current Biome config flags a small set of existing source/test files. This PR keeps that cleanup separate from the OMP parser work so either PR can be reviewed and merged independently.
What changed
anyannotations in test/e2e utilities withunknownor narrow local types.Verification
npm run lintcorepack pnpm@10 run buildcorepack pnpm@10 testcorepack pnpm@10 run checkReview notes
This is intentionally separate from #78. It can be merged before or after the OMP support PR.
Summary by cubic
Clean up to satisfy current Biome rules across sources and tests. No behavior changes; lint, build, and tests all pass.
node:built-in imports, template literals,parseIntradix, import order, and formatting.unknownguards, narrower types); simplified custom error classes.Written for commit 74fb017. Summary will update on new commits.