Skip to content

Relation query should be created by related class, not primary model class#550

Merged
Tigrov merged 8 commits intoyiisoft:masterfrom
batyrmastyr:relation_fix
May 2, 2026
Merged

Relation query should be created by related class, not primary model class#550
Tigrov merged 8 commits intoyiisoft:masterfrom
batyrmastyr:relation_fix

Conversation

@batyrmastyr
Copy link
Copy Markdown
Contributor

@batyrmastyr batyrmastyr commented Mar 19, 2026

Q A
Is bugfix? ✔️
New feature?
Breaks BC? ✔️/❌
Fixed issues #549

@batyrmastyr batyrmastyr changed the title Relation query should be created by related class, not primary model … Relation query should be created by related class, not primary model class Mar 19, 2026
@batyrmastyr batyrmastyr changed the title Relation query should be created by related class, not primary model class [WIP] Relation query should be created by related class, not primary model class Mar 19, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 0fdc2450-de59-41b2-a769-b66019e2c8c6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Tigrov
Copy link
Copy Markdown
Member

Tigrov commented Apr 20, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3bbca3f) to head (4744a81).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #550   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       656       656           
===========================================
  Files             43        43           
  Lines           1628      1629    +1     
===========================================
+ Hits            1628      1629    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tigrov Tigrov changed the title [WIP] Relation query should be created by related class, not primary model class Relation query should be created by related class, not primary model class May 2, 2026
@Tigrov Tigrov marked this pull request as ready for review May 2, 2026 12:55
@Tigrov Tigrov merged commit a217c4d into yiisoft:master May 2, 2026
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants