Fix indexed and associative values on upsert()

[Tigrov]

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	✔️/❌
Fixed issues	#559

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: cb8d62f6-b455-4260-b05c-2a382b8781f6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-indexed-and-associative-values

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3bbca3f) to head (c5b46d2).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##              master      #562   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       656       656           
===========================================
  Files             43        43           
  Lines           1628      1626    -2     
===========================================
- Hits            1628      1626    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[vjik]

This change doesn't fix #559. Try test https://github.com/yiisoft/active-record/pull/545/files/dc1ccc01420b562a7c675b133c4e8847baa40fd6#diff-92c77376ee7a3e05c7d19759a33ccf49dc59349133afca41cc551b8ab488bf17R361-R376

[Tigrov]

Yes, but perhaps #559 is not a bug. To avoid potential problems, we need to give priority to passed properties with values.

[vjik]

This change is OK. But I suggest don't close issue.

[vjik]

Add line to changelog