Skip to content

Fix #459: Add explicit Caddyfiles for dev and prod#460

Merged
samdark merged 2 commits intomasterfrom
explicit-caddyfile
Apr 12, 2026
Merged

Fix #459: Add explicit Caddyfiles for dev and prod#460
samdark merged 2 commits intomasterfrom
explicit-caddyfile

Conversation

@samdark
Copy link
Copy Markdown
Member

@samdark samdark commented Apr 12, 2026

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues #459

Copilot AI review requested due to automatic review settings April 12, 2026 13:14
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.08%. Comparing base (a75636d) to head (379512c).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #460   +/-   ##
=========================================
  Coverage     85.08%   85.08%           
  Complexity       29       29           
=========================================
  Files            11       11           
  Lines           181      181           
=========================================
  Hits            154      154           
  Misses           27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yiisoft yiisoft deleted a comment from coderabbitai Bot Apr 12, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds explicit FrankenPHP/Caddy Caddyfile configurations for Docker so dev and prod builds don’t rely on the image’s default config.

Changes:

  • Copy an explicit Caddyfile into the dev and prod Docker image stages.
  • Add new docker/dev/Caddyfile and docker/Caddyfile.
  • Update .dockerignore and CHANGELOG.md to include and document the new Caddyfiles.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
docker/Dockerfile Copies explicit Caddyfiles into dev/prod stages.
docker/dev/Caddyfile Introduces dev Caddy/FrankenPHP config.
docker/Caddyfile Introduces prod Caddy/FrankenPHP config.
.dockerignore Ensures Caddyfiles are included in the build context.
CHANGELOG.md Bumps “under development” version and documents #459.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docker/dev/Caddyfile Outdated
Comment thread docker/dev/Caddyfile Outdated
Comment thread docker/Caddyfile Outdated
Comment thread docker/Caddyfile Outdated
Comment thread docker/Dockerfile
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .dockerignore
@samdark samdark merged commit 10a61e4 into master Apr 12, 2026
24 checks passed
@samdark samdark deleted the explicit-caddyfile branch April 12, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants