Skip to content

Fix buildLimit() silently dropping OFFSET 0 #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vjik merged 4 commits into from
Apr 20, 2026
+2 −2
Merged

Fix buildLimit() silently dropping OFFSET 0 #1173

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
50a73f0
Fix buildLimit() silently dropping OFFSET 0
jmacias-cover Apr 2, 2026
4d5f5dd
Update parameter comments in DQLQueryBuilderInterface
Tigrov Apr 20, 2026
50bd9de
Apply suggestion from @Tigrov
Tigrov Apr 20, 2026
d7a6381
Merge branch 'master' into fix/build-limit-offset-zero
vjik Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/QueryBuilder/DQLQueryBuilderInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,9 @@ public function buildHaving(array|ExpressionInterface|string|null $condition, ar
public function buildJoin(array $joins, array &$params): string;

/**
* @param ExpressionInterface|int|null $limit The limit number.
* @param ExpressionInterface|int|null $limit The limit number. For ​​`null`, no limit clause is built.
* @see Query::limit() For more details.
* @param ExpressionInterface|int|null $offset The offset number.
* @param ExpressionInterface|int|null $offset The offset number. For ​​`null` or `0`, no offset clause is built.
* @see Query::offset() For more details.
*
* @throws NotSupportedException
Expand Down
Loading