fix(types): update stake_amount type to number or unlimited#5
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
This PR updates the backtest request typing and related UI code so stake_amount can be sent as a numeric value or the literal 'unlimited', aligning the frontend payload with the intended API shape and fixing related TypeScript issues in the UI.
Changes:
- Updated
BacktestPayload.stake_amounttonumber | 'unlimited'. - Adjusted
BacktestRun.vueto send numericstake_amount(instead of stringifying). - Added
valueprops toTabPanelinstances inTradeReasoning.vueto satisfy PrimeVue/TS expectations.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frequi/src/types/backtest.ts | Changes BacktestPayload.stake_amount type to `number |
| frequi/src/components/ftbot/BacktestRun.vue | Updates payload construction to pass stake amount as a number and supports 'unlimited'. |
| frequi/src/components/ai/TradeReasoning.vue | Adds tab value attributes to resolve PrimeVue Tabs/TS typing requirements. |
| frequi/src/components.d.ts | Regenerated/updated global component typings to include additional AI components. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changed the type of
stake_amountinBacktestPayloadto allow bothnumberand'unlimited'. AdjustedBacktestRun.vuestring conversion accordingly to avoid type mismatch. Fixed TS issues inTradeReasoning.vuewhere primevue Tabs expected avalue.PR created automatically by Jules for task 13228681352911552057 started by @ymcbzrgn