performance improvements part 2#10
Open
ynadji wants to merge 5 commits intotopic/yacin/performance-improvementsfrom
Open
performance improvements part 2#10ynadji wants to merge 5 commits intotopic/yacin/performance-improvementsfrom
ynadji wants to merge 5 commits intotopic/yacin/performance-improvementsfrom
Conversation
…parator from field boundaries
- Modify get-value :zeek branch to extract fields on-demand from offsets - Skip leading tab for fields idx>0 (offsets[i] points to separator) - Cache extracted values in row-strings (remains nil if never accessed) - Fix write-zeek-log-line :row-strings branch for nil entries (write from offsets) - Fix ensure-map :row-strings branch to preserve mutations from row-strings - Fix ensure-row to extract from offsets for unmaterialized fields - Harden compute-offsets for short/malformed lines (fewer tabs than expected) - All 194 tests pass, behavioral equivalence maintained
…cess [+8.9%] - Add :start/:end keyword arguments to fast-parse-double - Update get-value to pass offsets directly for numeric types (:double, :interval, :count, :int, :port) - Eliminates subseq allocation for @@column numeric field access - Benchmark: 8.9% improvement on @@column filter (1019ms -> 929ms)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no splits just offsets