-
Notifications
You must be signed in to change notification settings - Fork 0
Dev #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yoav-katz
wants to merge
108
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev #1
Changes from all commits
Commits
Show all changes
108 commits
Select commit
Hold shift + click to select a range
5cf883c
added ansible boilerplate
yoav-katz 81a9803
feat(haproxy): added haproxy role
yoav-katz f89d381
bla
yoav-katz 713637b
feat(keepalived): added keepalived functionality
yoav-katz 13fb643
fixes
yoav-katz 9eb9b4b
fix
yoav-katz 634c62c
bla
yoav-katz 9cf9aa5
bla
yoav-katz 9b0b878
bla
yoav-katz 7151433
fixed
yoav-katz 21c3df5
added boilerplate
yoav-katz df4b400
fixed
yoav-katz 609bfc5
fixe
yoav-katz 4814336
fix
yoav-katz 063dea8
bl
yoav-katz 36bbdd1
bl
yoav-katz 1ede2e9
bla
yoav-katz 3f277f0
b
yoav-katz 8d5d7c6
b
yoav-katz 84a57e8
bl
yoav-katz efd8fae
bla
yoav-katz 92f3c25
br
yoav-katz 9b7f066
bla
yoav-katz 8c3eaac
bl
yoav-katz 77bce73
s
yoav-katz d7fc486
bla
yoav-katz a5dfd3e
b
yoav-katz 332fa11
bl
yoav-katz bd83943
bls
yoav-katz 3bba01f
b
yoav-katz 100cf3e
d
yoav-katz 8ce39c8
b
yoav-katz be79ce5
adsadf
yoav-katz 2f80391
fix
yoav-katz 5ad0ff8
bfaads
yoav-katz c0e2f08
asdfasddfsadf
yoav-katz 3238ff9
dfgdfg
yoav-katz 00f93be
sfdasddf
yoav-katz 6af5ced
adfasdf
yoav-katz e2d0fbb
asgdsadg
yoav-katz 7d43e15
blasfasdsdfg
yoav-katz f64c515
asdfasdf
yoav-katz 8dd6b91
sadfasdfdasg
yoav-katz 097f6d7
afdasdf
yoav-katz 3662794
sdgasfd
yoav-katz f9a344d
adsfasdfa
yoav-katz 68871ac
adfasdfasf
yoav-katz b66b7a5
ASDFasdf
yoav-katz b197d98
sadfasdffsddfs
yoav-katz 350cc9e
asdfdass
yoav-katz 00ae3f3
asdfda
yoav-katz 45eae36
asdfasdf
yoav-katz 7a379a7
asdfda
yoav-katz a1d3ae1
asdfsaf
yoav-katz 9124694
safafasdf
yoav-katz 715f5ec
asdfasfd
yoav-katz e804c8c
asdfdsaf
yoav-katz 57b35ae
asdf
yoav-katz 9291d2b
asdffasfd
yoav-katz e3fe16d
asdf
yoav-katz a52bd62
adfasdf
yoav-katz cbb896f
asfdsa
yoav-katz cf5d507
asdfd
yoav-katz 782f5f8
adfsa
yoav-katz 7602e8e
asdfsadf
yoav-katz 684ade6
sadffafdsa
yoav-katz c28e25c
asdfsadF
yoav-katz 3aa49ef
asdfsafd
yoav-katz f7bb652
a
yoav-katz 6105c24
asdf
yoav-katz 70207df
asdfasdf
yoav-katz b28dd71
asdfsaf
yoav-katz 5e7c989
d
yoav-katz 9480169
adgadsf
yoav-katz 007ce92
asdfsdf
yoav-katz 44d188d
AFDsdf
yoav-katz a8849ab
adf
yoav-katz 9637e1a
adgadffsf
yoav-katz b996ee3
adsadf
yoav-katz b5d7f77
Asfd
yoav-katz 0d6e5b7
asdfsf
yoav-katz e493053
adsasdf
yoav-katz 8a92679
asdfsF
yoav-katz e591ee5
asdfs
yoav-katz 91a4971
asdfsaf
yoav-katz cd2a057
ASdfasf
yoav-katz 00bb347
sadfasdfsFD
yoav-katz 5645e80
Asdfsaf
yoav-katz 6b916d0
Asdfasfd
yoav-katz de4bfbc
Adfsaf
yoav-katz 97184ff
asdfsfd
yoav-katz abd94e0
asdfasfd
yoav-katz 346653b
asdfsadf
yoav-katz 3794860
adsfsfd
yoav-katz 1014e82
asdfsafd
yoav-katz abe0f36
SAdfsaf
yoav-katz 3e382d3
ASdfsadf
yoav-katz 258d14b
sdfsf
yoav-katz a5e7d9e
afdsdf
yoav-katz 19c4aff
asdfsAF
yoav-katz f22dc91
SADFasf
yoav-katz 4c060c2
AfdasDF
yoav-katz 59b6bfc
SadfasF
yoav-katz 76eb18e
ASDFasDF
yoav-katz e2c1e81
ASdfasFD
yoav-katz 62c62d4
sadfasdf
yoav-katz 64578e8
sadfasF
yoav-katz 555f47b
The Choosen One
yoav-katz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| .vscode/* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| [defaults] | ||
| roles_path = $HOME/ITtoolsTask/roles | ||
| inventory = $HOME/ITtoolsTask/inventory.ini | ||
| forks = 10 | ||
| remote_user = vagrant | ||
| become = False | ||
| ansible_python_interpreter = /usr/bin/python3.8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| [haproxy] | ||
| 192.168.0.2 keepalived_state=MASTER keepalived_priority=101 | ||
| 192.168.0.3 keepalived_state=BACKUP keepalived_priority=99 | ||
|
|
||
| [webserver] | ||
| 192.168.0.4 | ||
| 192.168.0.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| - name: Configure Task | ||
| hosts: all | ||
| become: true | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. try using the become only when necessary, and not all the time. |
||
| gather_facts: true | ||
| vars_files: | ||
| - vault.yml | ||
| vars: | ||
| keepalived_ip: 192.168.0.6 | ||
| tasks: | ||
| - name: Set subject_alt_names | ||
| set_fact: | ||
| subject_alt_names: "{{ groups['webserver'] | map('extract', hostvars, 'ansible_fqdn') | map('regex_replace', '^(.*)$', 'DNS:\\1') | join(',') }},DNS:keepalived.com,IP:{{ keepalived_ip }}" | ||
| when: "'haproxy' in group_names" | ||
|
|
||
| - name: Import apache Role | ||
| import_role: | ||
| name: "apache" | ||
| when: "'webserver' in group_names" | ||
|
|
||
| - name: Import haproxy Role | ||
| import_role: | ||
| name: "haproxy" | ||
| when: "'haproxy' in group_names" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| # handlers file for apache | ||
| - name: Restart Httpd | ||
| service: | ||
| name: httpd | ||
| state: restarted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| galaxy_info: | ||
| role_name: apache | ||
| author: Yoav Katz | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hhhhhhh |
||
| description: Creating httpd configuration with default index.html inside it | ||
| platforms: | ||
| - name: Centos8 | ||
| versions: | ||
| - all | ||
|
|
||
| license: MIT | ||
|
|
||
| min_ansible_version: 2.1 | ||
|
|
||
| dependencies: ['certificates'] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| --- | ||
| - name: Ensure httpd and his required packages ares installed. | ||
| dnf: | ||
| name: | ||
| - httpd | ||
| - mod_ssl | ||
| - openssh | ||
| state: present | ||
|
|
||
| - name: Generate httpd configuration | ||
| template: | ||
| src: httpd.conf.j2 | ||
| dest: /etc/httpd/conf/httpd.conf | ||
| validate: httpd -t -f %s | ||
| mode: 0644 | ||
| owner: apache | ||
| group: apache | ||
| notify: | ||
| - Restart Httpd | ||
|
|
||
| - name: Generate apache html | ||
| template: | ||
| src: index.html.j2 | ||
| dest: /var/www/html/index.html | ||
| mode: 0644 | ||
| owner: apache | ||
| group: apache | ||
|
|
||
| - name: Ensure httpd service is enabled | ||
| service: | ||
| name: httpd | ||
| state: started | ||
| enabled: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| ServerRoot "/etc/httpd" | ||
| ServerName {{ ansible_fqdn }} | ||
|
|
||
| Include conf.modules.d/*.conf | ||
|
|
||
| User apache | ||
| Group apache | ||
|
|
||
| <Directory /> | ||
| AllowOverride none | ||
| Require all denied | ||
| </Directory> | ||
|
|
||
| DocumentRoot "/var/www/html" | ||
|
|
||
| #Further relax access to the default document root: | ||
| <Directory "/var/www/html"> | ||
| Options Indexes FollowSymLinks | ||
| AllowOverride None | ||
| Require all granted | ||
| </Directory> | ||
|
|
||
| <VirtualHost *:443> | ||
| SSLEngine on | ||
| SSLCertificateKeyFile /etc/ssl/private/server.pem | ||
| SSLCertificateFile /etc/ssl/private/server.pem | ||
| SSLProtocol all -SSLv2 -SSLv3 | ||
| </VirtualHost> | ||
|
|
||
| <IfModule dir_module> | ||
| DirectoryIndex index.html | ||
| </IfModule> | ||
|
|
||
| <Files ".ht*"> | ||
| Require all denied | ||
| </Files> | ||
|
|
||
| ErrorLog "logs/error_log" | ||
|
|
||
| LogLevel warn | ||
|
|
||
| <IfModule log_config_module> | ||
| LogFormat "%h %l %u %t \"%r\" %>s %b \"%{Referer}i\" \"%{User-Agent}i\"" combined | ||
| LogFormat "%h %l %u %t \"%r\" %>s %b" common | ||
|
|
||
| <IfModule logio_module> | ||
| LogFormat "%h %l %u %t \"%r\" %>s %b \"%{Referer}i\" \"%{User-Agent}i\" %I %O" combinedio | ||
| </IfModule> | ||
|
|
||
| CustomLog "logs/access_log" combined | ||
| </IfModule> | ||
|
|
||
| <IfModule alias_module> | ||
| ScriptAlias /cgi-bin/ "/var/www/cgi-bin/" | ||
| </IfModule> | ||
|
|
||
| <Directory "/var/www/cgi-bin"> | ||
| AllowOverride None | ||
| Options None | ||
| Require all granted | ||
| </Directory> | ||
|
|
||
| <IfModule mime_module> | ||
| TypesConfig /etc/mime.types | ||
| AddType application/x-compress .Z | ||
| AddType application/x-gzip .gz .tgz | ||
| AddType text/html .shtml | ||
| AddOutputFilter INCLUDES .shtml | ||
| </IfModule> | ||
|
|
||
| AddDefaultCharset UTF-8 | ||
|
|
||
| <IfModule mime_magic_module> | ||
| MIMEMagicFile conf/magic | ||
| </IfModule> | ||
|
|
||
| EnableSendfile on | ||
| IncludeOptional conf.d/*.conf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| <html> | ||
| <head> | ||
| </head> | ||
| <body> | ||
| <h1>{{ ansible_nodename }}</h1> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| handler_to_notify: 'Restart Httpd' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| organization_details: | ||
| name: "Katz" | ||
| locality: "Tel Aviv" | ||
| country: "IL" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| galaxy_info: | ||
| role_name: certificates | ||
| author: Yoav Katz | ||
| description: Creating certificates to using a CA given as a variable | ||
| platforms: | ||
| - name: Centos8 | ||
| versions: | ||
| - all | ||
|
|
||
| license: MIT | ||
|
|
||
| min_ansible_version: 2.1 | ||
|
|
||
| dependencies: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| --- | ||
| - name: Ensure cryptography Package Installed | ||
| pip: | ||
| name: cryptography>=1.6 | ||
| state: present | ||
| extra_args: "--only-binary :all:" | ||
|
|
||
| - name: Generate private key | ||
| community.crypto.openssl_privatekey_pipe: | ||
| size: 2048 | ||
| register: host_private_key | ||
|
|
||
| - name: Create certificate signing request (CSR) for new certificate | ||
| community.crypto.openssl_csr_pipe: | ||
| privatekey_content: "{{ host_private_key.privatekey }}" | ||
| common_name: "{{ ansible_fqdn }}" | ||
| subject_alt_name: > | ||
| {{ | ||
| [ 'DNS:localhost', 'IP:' + inventory_hostname, 'DNS:' + ansible_fqdn ] + | ||
| ( subject_alt_names | default('') | split(',') | select('match', '.+') ) | ||
| }} | ||
| subject_alt_name_critical: true | ||
| organization_name: "{{ organization_details.name }}" | ||
| locality_name: "{{ organization_details.locality }}" | ||
| country_name: "{{ organization_details.country }}" | ||
| register: host_csr | ||
|
|
||
| - name: Sign the CSR using the CA | ||
| community.crypto.x509_certificate_pipe: | ||
| csr_content: "{{ host_csr.csr }}" | ||
| provider: ownca | ||
| ownca_path: /etc/ca/ca.crt | ||
| ownca_privatekey_path: /etc/ca/private/ca.key | ||
| ownca_not_before: "-1d" | ||
| ownca_not_after: +365d | ||
| register: host_crt | ||
| delegate_to: localhost | ||
|
|
||
| - name: Ensure /etc/ssl/private directory exists | ||
| file: | ||
| path: /etc/ssl/private/ | ||
| state: directory | ||
| mode: 0744 | ||
|
|
||
| - name: Assemble private key and certificate into PEM file | ||
| copy: | ||
| content: "{{ host_private_key.privatekey }}{{ host_crt.certificate }}" | ||
| dest: /etc/ssl/private/server.pem | ||
| mode: 0644 | ||
| notify: "{{ handler_to_notify }}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| # defaults file for haproxy | ||
| keepalived_ip: 192.168.0.6 | ||
| keepalived_subnet: 28 | ||
| keepalived_auth_pass: "1111" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| - name: Restart HAProxy | ||
| service: | ||
| name: haproxy | ||
| state: restarted | ||
|
|
||
| - name: Restart Keepalived | ||
| service: | ||
| name: keepalived | ||
| state: restarted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| galaxy_info: | ||
| role_name: haproxy | ||
| author: Yoav Katz | ||
| description: Creating haproxy with keepalived configuration that passes requests to webserver host group | ||
| platforms: | ||
| - name: Centos8 | ||
| versions: | ||
| - all | ||
|
|
||
| license: MIT | ||
|
|
||
| min_ansible_version: 2.1 | ||
|
|
||
| dependencies: ['certificates'] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| - name: Validate all keepalived host vars exists | ||
| assert: | ||
| that: | ||
| - keepalived_state in ['MASTER', 'BACKUP'] | ||
| - keepalived_priority is number | ||
| fail_msg: "to configure Keepalived all hosts hosting it needs: keepalived_state and keepalived_priority" | ||
|
|
||
| - name: Ensure Keepalived is installed. | ||
| dnf: | ||
| name: keepalived | ||
| state: present | ||
|
|
||
| - name: Generate Keepalived configuration | ||
| template: | ||
| src: keepalived.conf.j2 | ||
| dest: /etc/keepalived/keepalived.conf | ||
| validate: keepalived -t -f %s | ||
| mode: 0644 | ||
| owner: haproxy | ||
| group: haproxy | ||
| notify: Restart Keepalived | ||
|
|
||
| - name: Ensure Keepalive service is enabled | ||
| service: | ||
| name: keepalived | ||
| state: started | ||
| enabled: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| --- | ||
| - name: Ensure HAProxy is installed. | ||
| dnf: | ||
| name: haproxy | ||
| state: present | ||
|
|
||
| - name: Generate HAProxy configuration | ||
| template: | ||
| src: haproxy.cfg.j2 | ||
| dest: /etc/haproxy/haproxy.cfg | ||
| validate: haproxy -c -f %s | ||
| mode: 0644 | ||
| owner: haproxy | ||
| group: haproxy | ||
| notify: Restart HAProxy | ||
|
|
||
| - name: Ensure HAProxy service is enabled | ||
| service: | ||
| name: haproxy | ||
| state: started | ||
| enabled: true | ||
|
|
||
| - name: Generate keepalived | ||
| import_tasks: | ||
| file: keepalived.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| global | ||
| log /dev/log local0 info | ||
| user haproxy | ||
| group haproxy | ||
| daemon | ||
| maxconn 4000 | ||
| tune.ssl.default-dh-param 2048 | ||
|
|
||
| defaults | ||
| log global | ||
| option dontlognull | ||
| mode http | ||
| timeout connect 5000 | ||
| timeout client 50000 | ||
| timeout server 50000 | ||
|
|
||
| frontend ha-front-ssl | ||
| bind *:443 ssl crt /etc/ssl/private/server.pem | ||
| mode tcp | ||
| option tcplog | ||
| http-request set-header X-Forwarded-For %[src] | ||
| http-request add-header X-Forwarded-Proto https | ||
| option http-server-close | ||
| {% for server in groups['webserver'] %} | ||
| acl url_{{ hostvars[server].ansible_nodename }} hdr(host) -i {{ hostvars[server].ansible_fqdn }} | ||
| use_backend be_{{ hostvars[server].ansible_nodename }} if url_{{ hostvars[server].ansible_nodename }} | ||
| {% endfor %} | ||
|
|
||
| {% for server in groups['webserver'] %} | ||
| backend be_{{ hostvars[server].ansible_nodename }} | ||
| server {{ hostvars[server].ansible_nodename }} {{ hostvars[server].inventory_hostname }}:443 ssl verify required ca-file /etc/pki/ca-trust/source/anchors/root-CA.crt check | ||
| {% endfor %} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
call it main.yml, or something else, but not this