Update CI for current Rubies and modernize specs#17
Open
petergoldstein wants to merge 1 commit intoyolk:masterfrom
Open
Update CI for current Rubies and modernize specs#17petergoldstein wants to merge 1 commit intoyolk:masterfrom
petergoldstein wants to merge 1 commit intoyolk:masterfrom
Conversation
- CI matrix: drop EOL Rubies (2.7, 3.0, 3.1), add 3.3, 3.4, 4.0 - Update actions/checkout v3 → v6 - Gemfile: use HTTPS for rubygems.org - gemspec: remove rubyforge_project and unused sqlite3 dev dep - Specs: migrate from should syntax to expect syntax - Specs: replace before/@ivar with let Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkoutv3 → v6rubyforge_projectsetting and unusedsqlite3dev dependencyshouldsyntax toexpect/is_expected; replacebefore/@ivarwithletAll 42 specs pass on Ruby 4.0.
Test plan
bundle installsucceedsbundle exec rake— 42 examples, 0 failures🤖 Generated with Claude Code