Draft
Conversation
@abernier/camera-controls
…o canary-abernier-pkg
…o rm-module-closure-vars
…o rm-module-closure-vars
Rm module closure vars
release
abernier
commented
Aug 14, 2025
Comment on lines
-40
to
-62
| let THREE: THREESubset; | ||
| let _ORIGIN: _THREE.Vector3; | ||
| let _AXIS_Y: _THREE.Vector3; | ||
| let _AXIS_Z: _THREE.Vector3; | ||
| let _v2: _THREE.Vector2; | ||
| let _v3A: _THREE.Vector3; | ||
| let _v3B: _THREE.Vector3; | ||
| let _v3C: _THREE.Vector3; | ||
| let _cameraDirection: _THREE.Vector3; | ||
| let _xColumn: _THREE.Vector3; | ||
| let _yColumn: _THREE.Vector3; | ||
| let _zColumn: _THREE.Vector3; | ||
| let _deltaTarget: _THREE.Vector3; | ||
| let _deltaOffset: _THREE.Vector3; | ||
| let _sphericalA: _THREE.Spherical; | ||
| let _sphericalB: _THREE.Spherical; | ||
| let _box3A: _THREE.Box3; | ||
| let _box3B: _THREE.Box3; | ||
| let _sphere: _THREE.Sphere; | ||
| let _quaternionA: _THREE.Quaternion; | ||
| let _quaternionB: _THREE.Quaternion; | ||
| let _rotationMatrix: _THREE.Matrix4; | ||
| let _raycaster: _THREE.Raycaster; |
Collaborator
Author
There was a problem hiding this comment.
now static and accessible through this.ctor.* (more portable when subclassing)
abernier
commented
Aug 14, 2025
| @@ -1,6 +1,9 @@ | |||
| { | |||
| "name": "camera-controls", | |||
| "name": "@abernier/camera-controls", | |||
Collaborator
Author
There was a problem hiding this comment.
abernier
commented
Aug 14, 2025
| "dist" | ||
| ], | ||
| "repository": "yomotsu/camera-controls", | ||
| "repository": "abernier/camera-controls", |
abernier
commented
Aug 14, 2025
abernier
commented
Aug 14, 2025
Comment on lines
+3
to
+5
| - name: canary-* | ||
| prerelease: true | ||
| channel: canary |
Collaborator
Author
There was a problem hiding this comment.
support for canary release for canary-* branches
abernier
commented
Aug 14, 2025
Collaborator
Author
There was a problem hiding this comment.
chromatic integration ❤️
abernier
commented
Aug 14, 2025
Collaborator
Author
There was a problem hiding this comment.
i've exported more useful stuff
abernier
commented
Aug 14, 2025
* setup * ci * . * .
* CameraControlsState["spherical"] * add a test * simpler test
release
abernier
commented
Aug 15, 2025
Comment on lines
+1
to
+7
| [](https://www.npmjs.com/package/@abernier/camera-controls) | ||
| [](https://dev--68888af2a4f99a664aba1eb5.chromatic.com) | ||
| [](https://www.chromatic.com/library?appId=68888af2a4f99a664aba1eb5&branch=dev) | ||
|
|
||
| this is my fork of original [yomotsu/camera-controls](https://github.com/yomotsu/camera-controls) | ||
|
|
||
| <details> |
Owner
|
@abernier |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
DO NOT MERGE as is
Warning
see⚠️ in review: some changes are fork's specific
this PR shows the work of my fork abernier/camera-controls