README: fix arg in generate_signed_url#6
Open
hannahcancode wants to merge 1 commit intoyongfook:masterfrom
Open
README: fix arg in generate_signed_url#6hannahcancode wants to merge 1 commit intoyongfook:masterfrom
generate_signed_url#6hannahcancode wants to merge 1 commit intoyongfook:masterfrom
Conversation
- The second arg for `generate_signed_url` needs to be just an array rather than an object with a `modifications` key to create a valid signed url.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was attempting to create a signed url using this package following the README instructions but I was getting an error. I realised the example code in the README was different to the instructions provided when you create the signed url base, this PR updates the example code to correct that.
generate_signed_urlneeds to be just an array ratherthan an object with a
modificationskey to create a valid signed url.