Conversation
|
Can you resolve the conflicts? |
uehler
force-pushed
the
one-class-per-file
branch
from
ac0a354 to
994df4d
Compare
|
done @localheinz |
src/Api.php
Outdated
| use function curl_close; | ||
| use function curl_errno; | ||
| use function curl_error; | ||
| use function curl_exec; | ||
| use function curl_getinfo; | ||
| use function curl_init; | ||
| use function curl_setopt; | ||
| use function curl_setopt_array; | ||
| use function json_decode; | ||
| use function json_encode; |
There was a problem hiding this comment.
Not sure about importing these functions from the root namespace - the original file does not import:
bannerbear-php/src/BannerbearClient.php
Lines 1 to 6 in 493b936
There was a problem hiding this comment.
It's just micro optimizations
There was a problem hiding this comment.
I know, but it's an unrelated change.
We could use friendsofphp/php-cs-fixer with the global_namespace_import fixer configured and enabled to make that change in a separate pull request.
What do you think?
There was a problem hiding this comment.
I reverted the imports
src/Api.php
Outdated
| @@ -0,0 +1,105 @@ | |||
| <?php declare(strict_types=1); | |||
There was a problem hiding this comment.
Can you also remove this declaration? The original file does not declare strict types.
2 participants
in php each class has its own file