refactor(ui): centralize canvas state and AppMark semantics#367
Closed
Harry19081 wants to merge 2 commits into
Closed
refactor(ui): centralize canvas state and AppMark semantics#367Harry19081 wants to merge 2 commits into
Harry19081 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useCanvasForTurnand the session store helpersuseCanvasPreviewForSessioncompatibility shim and replace duplicated state reads/mutations across chat, streaming, pinned actions, session sync, and tab renderingAppMarkto use clearer inline semantics, memoized rendering, reusable path constants, and optional accessible title supportWhy
Canvas preview state was being derived and mutated from multiple consumers, which made session boundaries and visibility rules easier to drift. This extraction keeps those rules in one place.
AppMarkcurrently has no production caller, so that commit has no user-visible effect until the component is used.Existing overlap
The Canvas portion overlaps with the broader work in #281. This PR is a smaller, independently validated extraction; reviewers can choose whether to land it separately or fold it into #281.
The updater and pill work are intentionally excluded because equivalent PRs already exist.
Validation
pnpm typecheckgit diff --checkNo standalone AppMark behavioral test was added because the component currently has no caller.