Skip to content

fix(agent-org-ui): align recovery, plan approval, and task state#381

Closed
Harry19081 wants to merge 3 commits into
fix/issue-272-agent-org-recovery-backendfrom
fix/issue-272-agent-org-recovery-frontend
Closed

fix(agent-org-ui): align recovery, plan approval, and task state#381
Harry19081 wants to merge 3 commits into
fix/issue-272-agent-org-recovery-backendfrom
fix/issue-272-agent-org-recovery-frontend

Conversation

@Harry19081

Copy link
Copy Markdown
Member

Summary

Fixes #272 after the backend stack lands.

This is the frontend half of #373. It projects the durable Agent Org backend state introduced by #380 into Group Chat, plan approval, task/Kanban views, settings, structured tool guidance, and rendered E2E coverage.

Depends on: #380
Combined reference: #373

What changed

  • Adds explicit Agent Org Run phases: coordinating, dispatching, members working, waiting, awaiting plan approval, finalizing, paused, and terminal states.
  • Adds the Group Chat plan-approval card with approve, edit-and-approve, request-changes, feedback, loading, and inline error states.
  • Surfaces durable plan approvals, TaskOutput, member activity, and completion-certificate state from the backend contracts.
  • Aligns Team Tasks, Workstation Kanban, event bubbles, task blocks, and task outcome parsing.
  • Distinguishes expected task constraints from real system failures so normal coordinator corrections do not appear as unexplained red failures.
  • Adds Agent Org plan-approval policy settings and keeps unsupported CLI members out of Agent Org-specific pickers.
  • Synchronizes English and Chinese copy.
  • Adds rendered E2E coverage for Group Chat recovery, approval, dependency order, pause/resume, finality, and settings paths.

Review boundaries

Relative to #380, this PR contains:

  • 40 files under src/**
  • 4 Agent Org browser E2E files
  • 3 frontend UI audit reports
  • No src-tauri/** files

The stacked frontend tree plus #380 is byte-for-byte identical to the combined #373 snapshot 78338c38a.

Merge order

  1. Review and merge fix(agent-org): harden recovery, task orchestration, and run finality #380 into develop.
  2. Retarget this PR from fix/issue-272-agent-org-recovery-backend to develop.
  3. Merge the latest develop normally if needed; do not rebase or force-push.
  4. Reconfirm this PR still shows only frontend/E2E/audit files.

Verification

  • Agent Org Vitest: 25 passed
  • pnpm run lint — passed
  • pnpm run check:circular — no circular dependencies
  • Husky scoped TypeScript check — passed for all 36 staged TS/TSX files
  • node --check — passed for all 4 changed E2E modules
  • Split boundary check — frontend diff contains only src/**, Agent Org browser E2E, and frontend audit files
  • Combined tree equality check against fix(agent-org): harden recovery, task orchestration, and run finality #373 78338c38a — passed
  • Original combined branch completed live Agent Org manual verification

Known target-branch baseline

Full pnpm run typecheck reports one unchanged develop error:

src/engines/ChatPanel/InputArea/components/ContextInfoButton.tsx:468
Type 'string | undefined' is not assignable to type 'string'

That file is outside this PR diff.

Split the TypeScript contracts, Group Chat projections, plan approval controls, task outcome handling, settings, and UI unit coverage from the combined #373 change so the frontend can be reviewed on top of the backend contract.

Verification:
- npx vitest run Agent Org frontend tests (25 passed)
- pnpm run lint
- pnpm run check:circular (0 cycles)
- pnpm run typecheck (only unchanged develop error at ContextInfoButton.tsx:468)
- git diff --cached --check

Pre-commit hook ran. Total eslint: 0, total circular: 0
Keep the rendered Group Chat, recovery, plan approval, pause/resume, task-state, and settings scenarios in a dedicated frontend test commit for the stacked #373 split.

Verification:
- node --check on all four changed Agent Org E2E modules
- git diff --cached --check
- Original combined branch completed live Agent Org manual verification

Pre-commit hook ran. Total eslint: 0, total circular: 0
Keep the CLI parity, planner approval, and final UI audit decisions with the frontend half of the #373 split so reviewers retain the original design rationale.

Verification:
- git diff --cached --check

Pre-commit hook ran. Total eslint: 0, total circular: 0
@ShiboSheng

Copy link
Copy Markdown
Collaborator

Closed only to correct the PR creator identity. Replacement Frontend PR: #383.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants