perf(polling): pause background refreshes when hidden#400
Open
beruro wants to merge 3 commits into
Open
Conversation
Pre-commit hook ran. Total eslint: 0, total circular: 0
Pre-commit hook ran. Total eslint: 1, total circular: 0
fix(i18n): complete locale coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/architecture-audit-2026-07-16/PollingLifecycle.mdAudit findings resolved
The pre-commit architecture audit found and fixed two blocking race classes:
RepoStatebefore recreation, which could destroy fallback/retry metadata on failureThe final re-audit verdict is safe to commit / PR.
Verification
pnpm exec eslinton all 36 changed frontend source/test filespnpm exec vitest run src/hooks/fileReview src/hooks/platform/useInlineWebview/__tests__/useWebviewCommands.test.ts src/modules/WorkStation/Browser/SessionReplay/__tests__/config.test.ts src/scaffold/NavigationSidebar/connectors/WorkstationSidebarConnector/menuSelection.test.ts— 10 tests passedcargo fmt --manifest-path crates/git/Cargo.toml --checkcargo test -p git --lib— 129 tests passedcargo clippy -p git --all-targets -- -D warningsgit diff --checkScope notes
junyu/hermes-hook-status) because several touched polling consumers were changed on that branch.useDataSourceAutoScan; an independent focus-adaptive implementation landed ondevelopas5be17525bwhile this audit was running.Dependency
developif GitHub does not update the base automatically.