Fix clippy by latest rust / solve hashbrown deps

deny.toml

@@ -178,6 +178,7 @@ deny = [
 
 # Certain crates/versions that will be skipped when doing duplicate detection.
 skip = [
+    { name = "hashbrown" },
 ]
 # Similarly to `skip` allows you to skip certain crates during duplicate
 # detection. Unlike skip, it also includes the entire tree of transitive

pubsub/src/apiv1/publisher_client.rs

@@ -134,7 +134,7 @@ impl PublisherClient {
                     .map_transient_err()
             };
             let response = invoke(retry.clone(), action).await?;
-            all.extend(response.topics.into_iter());
+            all.extend(response.topics);
             if response.next_page_token.is_empty() {
                 return Ok(all);
             }
@@ -163,7 +163,7 @@ impl PublisherClient {
                     .map_transient_err()
             };
             let response = invoke(retry.clone(), action).await?;
-            all.extend(response.subscriptions.into_iter());
+            all.extend(response.subscriptions);
             if response.next_page_token.is_empty() {
                 return Ok(all);
             }
@@ -196,7 +196,7 @@ impl PublisherClient {
                     .map_transient_err()
             };
             let response = invoke(retry.clone(), action).await?;
-            all.extend(response.snapshots.into_iter());
+            all.extend(response.snapshots);
             if response.next_page_token.is_empty() {
                 return Ok(all);
             }

pubsub/src/apiv1/schema_client.rs

@@ -79,7 +79,7 @@ impl SchemaClient {
                     .map_transient_err()
             };
             let response = invoke(retry.clone(), action).await?;
-            all.extend(response.schemas.into_iter());
+            all.extend(response.schemas);
             if response.next_page_token.is_empty() {
                 return Ok(all);
             }

pubsub/src/apiv1/subscriber_client.rs

@@ -147,7 +147,7 @@ impl SubscriberClient {
                     .map_transient_err()
             };
             let response: ListSubscriptionsResponse = invoke(retry.clone(), action).await?;
-            all.extend(response.subscriptions.into_iter());
+            all.extend(response.subscriptions);
             if response.next_page_token.is_empty() {
                 return Ok(all);
             }
@@ -331,7 +331,7 @@ impl SubscriberClient {
                     .map_transient_err()
             };
             let response: ListSnapshotsResponse = invoke(retry.clone(), action).await?;
-            all.extend(response.snapshots.into_iter());
+            all.extend(response.snapshots);
             if response.next_page_token.is_empty() {
                 return Ok(all);
             }

spanner/src/admin/database/database_admin_client.rs

@@ -54,7 +54,7 @@ impl DatabaseAdminClient {
                     .map_transient_err()
             };
             let response = invoke(retry.clone(), action).await?;
-            all_databases.extend(response.databases.into_iter());
+            all_databases.extend(response.databases);
             if response.next_page_token.is_empty() {
                 return Ok(all_databases);
             }
@@ -340,7 +340,7 @@ impl DatabaseAdminClient {
                     .map_transient_err()
             };
             let response = invoke(retry.clone(), action).await?;
-            all_backups.extend(response.backups.into_iter());
+            all_backups.extend(response.backups);
             if response.next_page_token.is_empty() {
                 return Ok(all_backups);
             }
@@ -413,7 +413,7 @@ impl DatabaseAdminClient {
                     .map_transient_err()
             };
             let response = invoke(retry.clone(), action).await?;
-            all_operations.extend(response.operations.into_iter());
+            all_operations.extend(response.operations);
             if response.next_page_token.is_empty() {
                 return Ok(all_operations);
             }
@@ -450,7 +450,7 @@ impl DatabaseAdminClient {
                     .map_transient_err()
             };
             let response = invoke(retry.clone(), action).await?;
-            all_operations.extend(response.operations.into_iter());
+            all_operations.extend(response.operations);
             if response.next_page_token.is_empty() {
                 return Ok(all_operations);
             }

spanner/src/admin/instance/instance_admin_client.rs

@@ -51,7 +51,7 @@ impl InstanceAdminClient {
                     .map_transient_err()
             };
             let response = invoke(retry.clone(), action).await?;
-            all.extend(response.instance_configs.into_iter());
+            all.extend(response.instance_configs);
             if response.next_page_token.is_empty() {
                 return Ok(all);
             }
@@ -102,7 +102,7 @@ impl InstanceAdminClient {
                     .map_transient_err()
             };
             let response = invoke(retry.clone(), action).await?;
-            all.extend(response.instances.into_iter());
+            all.extend(response.instances);
             if response.next_page_token.is_empty() {
                 return Ok(all);
             }