Support recursive mount attrs by using mount_setattr(2).#1398
Merged
utam0k merged 2 commits intoyouki-dev:mainfrom Dec 13, 2022
Merged
Support recursive mount attrs by using mount_setattr(2).#1398utam0k merged 2 commits intoyouki-dev:mainfrom
utam0k merged 2 commits intoyouki-dev:mainfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1398 +/- ##
==========================================
+ Coverage 68.80% 69.02% +0.21%
==========================================
Files 119 119
Lines 12664 13041 +377
==========================================
+ Hits 8713 9001 +288
- Misses 3951 4040 +89 |
higuruchi
force-pushed
the
Support/Recursive_mount_attrs
branch
2 times, most recently
from
c1f61f3 to
7e886ad
Compare
Signed-off-by: higuruchi <fumiya2324@gmail.com>
higuruchi
force-pushed
the
Support/Recursive_mount_attrs
branch
from
7e886ad to
7c4ff41
Compare
utam0k
reviewed
Dec 8, 2022
utam0k
reviewed
Dec 8, 2022
utam0k
reviewed
Dec 8, 2022
utam0k
reviewed
Dec 8, 2022
utam0k
reviewed
Dec 8, 2022
utam0k
requested changes
Dec 8, 2022
Member
utam0k
left a comment
utam0k
left a comment
There was a problem hiding this comment.
Thanks for your PR. Awesome. I left some comments
higuruchi
force-pushed
the
Support/Recursive_mount_attrs
branch
7 times, most recently
from
afa6111 to
f25f745
Compare
Implemented MountAttrOption enum. Signed-off-by: higuruchi <fumiya2324@gmail.com>
higuruchi
force-pushed
the
Support/Recursive_mount_attrs
branch
from
f25f745 to
0631de9
Compare
utam0k
reviewed
Dec 13, 2022
| MountAttrNosymfollow(bool, u64), | ||
| } | ||
|
|
||
| impl FromStr for MountAttrOption { |
utam0k
approved these changes
Dec 13, 2022
Member
utam0k
left a comment
utam0k
left a comment
There was a problem hiding this comment.
@higuruchi May I ask you to add a test about this in another PR? If you don't have time, please create the issue, and we can take over from you.
Contributor
Author
|
I have never written a test for youki, can I try it? |
Member
@higuruchi Sure! If you have trouble or a question about that, please create the issue and ping me or @YJDoc2 (He is a professional for our integration test) |
Collaborator
|
@higuruchi Sure, let me know if you face any issues. Currently #361 is used to track porting of OCI integration tests, you can take a look at it and start from there 👍 |
18 tasks
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement "rro" mount option that implemented in runc(opencontainers/runc#3272) and crun(containers/crun#778).
This mount option "rro" makes the mount point recursively read-only, by calling mount_setattr(2) with MOUNT_ATTR_RDONLY and AT_RECURSIVE.
Signed-off-by: higuruchi fumiya2324@gmail.com