fix: strip Slack approval buttons immediately on click#51
Merged
yourbuddyconner merged 1 commit intoMay 9, 2026
Merged
Conversation
The interactive handler returned 200 to Slack right away (to meet the 3-second ack deadline) and only updated the message via chat.update after the DO finished executing the approved action. For slow tool calls that gap was many seconds, during which Slack dropped its spinner but the buttons stayed enabled — letting users re-click Approve/Deny while processing was already underway. Now we POST to the payload's response_url before scheduling the DO call to replace the actions block with a "⏳ Processing…" context. The DO's existing final-state chat.update still runs at the end and overwrites with "✅ Approved by …" / "❌ Denied by …".
Collaborator
Author
|
We really need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/worker/src/routes/slack-events.ts:659), which dropped Slack's spinner, but the message wasn't actually updated until the DO finishedexecuteActionAndSend(session-agent.ts:5836) and only then calledchat.update. On slow actions that gap was many seconds, during which users could re-click Approve.response_urlwithreplace_original: trueand the original blocks minus theactionsblock, plus a "⏳ Processing…" context line. The DO's existing final-statechat.updatestill runs at the end and overwrites with "✅ Approved by …" / "❌ Denied by …".ChannelTransportinterface change. Wrapped in try/catch — ifresponse_urlfails the old behavior is preserved.Test plan
pnpm typecheckpasses (verified locally)ENVIRONMENT=dev make deploy-workermake logs-cloudflarefor[Slack Interactive] response_url update failedwarnings — should be zero