Non-visible views and OnScreenSwitchListener#15
Open
RedHatter wants to merge 2 commits into
Open
Conversation
Owner
|
Thanks for the contribution, but this library is obsoleted by Google's release of their own ViewPager library as part of the Android Compatibility Package (since compatlib rev 3). I would recommend using that for any new development; this library is not maintained any longer, and I can't see any advantage to using this over Google's official blessed implementation. |
Author
|
Google's ViewPager is several times more complex to use. So if a simple pager is needed for a small part the project works much better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
horizontalpagerhad a child view that had visibility set toView.GONEit would correctly not callonLayoutfor it, but would incorrectly still take it into account in other calculations. This behavior would cause an empty black screen to appear at the end. My patch fixes this by not counting children withView.GONEset.My patch also adds
onScreenSelectedtoOnScreenSwitchListenerto notify user about a new screen but before the animation.