Add tests for splitTextIntoSentences#218
Open
ysdede wants to merge 1 commit into
Open
Conversation
Added comprehensive tests for the `splitTextIntoSentences` function in `src/sentence_boundary.js`. Coverage includes happy paths for normal NLP usage, testing the fallback to heuristic chunking when `useNLP: false`, and verifying edge cases such as empty, null, or undefined strings.
This comment has been minimized.
This comment has been minimized.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
ysdede
changed the title
ysdede
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: The testing gap addressed: Missing tests for
splitTextIntoSentencesinsrc/sentence_boundary.js.Coverage: Tests now cover happy paths (splitting typical sentences with winkNLP), edge cases (empty strings, null, undefined, whitespace-only strings), and fallback behavior for heuristic splitting when
config.useNLP === false.Result: Increased test coverage and confidence in sentence boundary detection logic across both execution paths (NLP and RegEx heuristics).
PR created automatically by Jules for task 5434716196038362840 started by @ysdede
Summary by Sourcery
Tests: