docs: improve README and align flake update workflow#664
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the onboarding and maintenance experience for the dotfiles repository by providing extensive documentation and standardizing the Nix flake update process. The changes make it easier for users to understand the repository's structure, set up their environment, and manage their system configurations consistently. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request significantly improves the documentation in README.md and aligns the flake update workflow by standardizing the hostname to Mac. The changes are consistent across the modified files. I have one suggestion for the scripts/update-all.sh script to make its behavior more aligned with its name by including the nix flake update command.
| # pass secret as shell args to prevent leakage in ps aux | ||
| # sh -c 'nix --option extra-access-tokens "github.com=${1}" flake update' sh "${GITHUB_TOKEN}" | ||
| sudo sh -c 'nix --option extra-access-tokens "github.com=${1}" run nix-darwin -- switch --flake .' sh "${GITHUB_TOKEN}" | ||
| sudo sh -c 'nix --option extra-access-tokens "github.com=${1}" run nix-darwin -- switch --flake .#Mac' sh "${GITHUB_TOKEN}" |
There was a problem hiding this comment.
The script is named update-all.sh, which implies it updates everything. However, it doesn't update the flake inputs (via nix flake update), which can be misleading. To make the script's behavior match its name and provide a more complete update workflow, consider including the flake update command. This will ensure your flake's dependencies are updated before rebuilding the system.
| sudo sh -c 'nix --option extra-access-tokens "github.com=${1}" run nix-darwin -- switch --flake .#Mac' sh "${GITHUB_TOKEN}" | |
| sh -c 'nix --option extra-access-tokens "github.com=${1}" flake update' sh "${GITHUB_TOKEN}" | |
| sudo sh -c 'nix --option extra-access-tokens "github.com=${1}" run nix-darwin -- switch --flake .#Mac' sh "${GITHUB_TOKEN}" |








No description provided.