Fix performance bug: Bad value context for argument value

[NightRa]

Using arguments in a dynamic way in a function leads to the JIT (v8) not optimizing the whole function, with the error: "Bad value context for argument value". See GoogleChrome/devtools-docs#53 (comment) and Note gist.

This commit wraps the parse function with handling of arguments, and calls into the regular function with the args array, and now it can be optimized.

This fix improved performance almost 2x for me, from 17s to 9s. (for 500Kb of text so there's still room for improvement)

[GerHobbelt]

@NightRa : nice catch, this one! Since you seem interested in maximum performance jison parsers, you may be interested in GerHobbelt@d2f8af7
(with some more performance-related work done in
GerHobbelt@e44add3 ).

The thought there is that

• creating a function wrapped in another plus bind() is also rather costly (jsperf is down unfortunately, but old tests there indicated that .bind() is not exactly the fastest kid on the block)
• we already know exactly which extra arguments will be passed to the parse() API as these arguments are listed in the grammar file in the %parse-params option line

==> that made me wonder: "Why don't we take the %parse-params argument list and inject straight away into the code instead of messing with this arguments semi-array at all?" and those two referenced commits above are the result.

---

Thanks you for your work; I had not realized the high cost of arguments+slice in the parser core yet. 👍