Skip to content

Add "file" and "system" packages to depedencies#68

Open
rogeriopvl wants to merge 1 commit intozaach:masterfrom
rogeriopvl:missing-dependencies
Open

Add "file" and "system" packages to depedencies#68
rogeriopvl wants to merge 1 commit intozaach:masterfrom
rogeriopvl:missing-dependencies

Conversation

@rogeriopvl
Copy link
Copy Markdown

This fixes #57

@zaach jsonlint is kind of abandoned. Let me know if you need help maintaining this project. I would be glad to help out :)

@zaach
Copy link
Copy Markdown
Owner

zaach commented Oct 13, 2015

file and system... wait a sec, are those from the old support of Narwhal in jison?? Um, it might be time to regenerate the parser.

@ronkorving
Copy link
Copy Markdown

It might also be time to add contributors :) (no sarcasm intended)

@evaliyev
Copy link
Copy Markdown

Please merge this pull request!

@prantlf
Copy link
Copy Markdown

prantlf commented May 19, 2019

Why do the packages file and system have to be added to the dependencies of this package? And not just to "devDependencies", but to "dependencies". As such they would get installed by anyon, including people, who do not work with browserify. Should not those projects, which use browserify, depend on those two packages in their package.json files?

@evaliyev
Copy link
Copy Markdown

system and file are used in lib/jsonlint.js in the node environment at runtime (https://github.com/zaach/jsonlint/blob/master/lib/jsonlint.js#L430 and https://github.com/zaach/jsonlint/blob/master/lib/jsonlint.js#L424). I would leave them in dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot browserify jsonlint: module "file" missing

5 participants