Skip to content

publish #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zaewc merged 2 commits into from
Apr 20, 2026
Merged

publish #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
604c760
chore: bundle
zaewc Apr 20, 2026
1e3f453
chore: workspace
zaewc Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "scrolloop",
"version": "0.5.0",
"version": "0.5.1",
"repository": {
"type": "git",
"url": "git+https://github.com/976520/scrolloop.git"
Expand All @@ -10,6 +10,7 @@
"workspaces": [
"packages/*"
],
"bundle": true,
"packageManager": "pnpm@10.20.0",
"main": "./packages/react/dist/index.cjs",
"module": "./packages/react/dist/index.mjs",
Expand Down Expand Up @@ -97,5 +98,9 @@
"vitepress": "^1.6.4",
"vitest": "^2.0.0",
"vue": "^3.5.26"
},
"dependencies": {
"@scrolloop/core": "workspace:*",
"@scrolloop/shared": "workspace:*"
}
Comment on lines +102 to 105
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since @scrolloop/core and @scrolloop/shared are configured to be bundled into the build output (as indicated by the noExternal setting in tsup.config.ts), they should be moved to devDependencies. Listing them in dependencies will cause them to be installed as separate runtime packages by consumers, which is redundant and increases the installation footprint unnecessarily when the code is already included in the bundle.

}
7 changes: 7 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions tsup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export default defineConfig({
clean: true,
minify: true,
external: ["react", "react-dom"],
noExternal: ["@scrolloop/core", "@scrolloop/shared"],
outExtension({ format }) {
return {
js: format === "esm" ? ".mjs" : ".cjs",
Expand Down
Loading