fix: replace mutable default argument in override_dist_dtype_device_args#554
Open
Mr-Neutr0n wants to merge 1 commit intozai-org:mainfrom
Open
fix: replace mutable default argument in override_dist_dtype_device_args#554Mr-Neutr0n wants to merge 1 commit intozai-org:mainfrom
Mr-Neutr0n wants to merge 1 commit intozai-org:mainfrom
Conversation
Using a mutable default argument (b={}) is a known Python pitfall:
the dict is created once at function definition time and shared across
all calls, which can lead to subtle, hard-to-diagnose bugs when the
dict is mutated.
Replace `b={}` with `b=None` and initialize inside the function body
in both cogvlm_model.py and cogagent_model.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
b={}withb=Noneinoverride_dist_dtype_device_argsin bothutils/models/cogvlm_model.pyandutils/models/cogagent_model.pybto{}inside the function body whenNoneis passedMotivation
Using a mutable default argument (
b={}) is a well-known Python anti-pattern (docs). The default dict is created once at function definition time and shared across all calls. If it is ever mutated, the mutation persists into subsequent calls, leading to subtle and hard-to-diagnose bugs.Changes
utils/models/cogvlm_model.py(line 38):utils/models/cogagent_model.py(line 39):Same fix applied.
Test plan