Drop redundant brand/title top bar from the private /v viewer#527
Merged
Conversation
A member reaches /v already authenticated via a publish handoff, so the Wordmark + artifact-title header is redundant chrome. The anti-phishing brand affordance lives only on the public /al access-link viewer, where the recipient is unauthenticated and needs proof of origin. Render the live viewer full-bleed inside an h-screen wrapper. Issue: AP-329 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
First-pass review
Risk: simple
Decision: approve
Ticket triage (AP-329)
- Intended change: Remove the redundant Wordmark + artifact-title header from the login-walled private
/v/$artifactIdviewer so the live iframe renders full-bleed. - Scope match: Yes — single-file change in
apps/web/src/routes/v.$artifactId.tsxexactly as specified./aland dashboard routes untouched.
Review findings
Blocking: None.
Non-blocking:
apps/web/test/v-route.test.tsxstill mocks@agent-paste/uiWordmarkeven though the route no longer imports it. Harmless today; could be dropped in a follow-up for test hygiene.
Merge checklist
- Ticket linked: AP-329 attached
- Scope matches ticket: yes
- Checks green: Validate + Local smoke succeeded; Postgres smoke, CodeQL, secret scan passed
- Tests/docs appropriate: existing
/vroute tests cover the security-relevant loader contract andchrome={false}render; no new tests required for pure chrome removal - No blocking findings: yes
- No high-risk areas: UI-only; auth gate and member provisioning unchanged
- Merge-safe: yes
Why this is safe
The private viewer is already login-walled via loadAuthedSessionFn; removing dashboard navigation chrome does not weaken auth. The anti-phishing brand affordance correctly remains on /al only (per AP-310). Layout uses h-screen + ArtifactLiveViewer chrome={false} (h-full), which should fill the viewport without the old flex header offset.
Sent by Cursor Automation: First Pass PR Reviewer
|
agent-paste PR preview resources were cleaned up. The shared Preview GitHub Environment is retained for future preview deploys. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
The private published viewer (
/v/$artifactId) shipped a top bar with the Agent Paste wordmark and the artifact title. A member only reaches/vafter authenticating through a publish handoff, so that brand/title chrome is redundant. The anti-phishing brand affordance belongs only on the public/al/$publicIdaccess-link viewer, where the recipient is unauthenticated and needs proof of origin (that bar was built in AP-310). This removes the header and renders the live viewer full-bleed.Changes
apps/web/src/routes/v.$artifactId.tsx: remove the<header>(Wordmark + artifact title) and the now-unusedWordmark/Linkimports; renderArtifactLiveViewer(stillchrome={false}) inside a full-heighth-screenwrapper.Risk: LOW
/vprivate viewer). Login wall (loadAuthedSessionFn) and member provisioning are unchanged./alviewer, or any data path. The/alanti-phishing brand bar is unaffected.Test plan
pnpm verify(full local gate, green)pnpm --filter @agent-paste/web test(331 passed)/vheader;/albrand bar untouchedIssue: AP-329
@coderabbitai ignore