WIP: Allow NodePort type for master service#1584
Closed
ockl wants to merge 1 commit intozalando:masterfrom
ockl:nodeport
Closed
WIP: Allow NodePort type for master service#1584ockl wants to merge 1 commit intozalando:masterfrom ockl:nodeport
ockl wants to merge 1 commit intozalando:masterfrom
ockl:nodeport
Conversation
This commit introduces new property to a postgresql spec serviceNodePort. It enable NodePort type service for master role with automatic port allocation if value is 0. Othewise it takes desired port number like 30025. fixes: #983 Signed-off-by: Dinar Valeev <k0da@opensuse.org>
Member
|
When introducing a new field to the postgres CRD type, we have to update:
That is also missing in the original PR (which I forgot to comment 😞 ) |
|
@ockl what happened to this one? Is it in a position for someone else to approach again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to fix abandoned PR #994