Feature/timelineid in clone section

[Sudeepta92]

Add timelineid in clone section in the cluster CRD.

In the cluster config we need timeline_id along with the existing possibility of timestamp and cluster name such as for eg:

clone: 
    cluster: my-cluster-xyz # original cluster
    timestamp: "2022-07-11T12:19:35+00:00"   
    clone_target_timeline: "2" 

[FxKu]

Please use go.fmt for right code formatting. This is misaligned.
And type should better be int32. I know it's used as an environment variable later but we can enforece users to only specify numbers here.

[Sudeepta92]

The type has been changed and the formatting is corrected.

[FxKu]

I think, we should not use the same name as the Spilo environment variable. We have also omitted the clone_ prefix from other variables. How about wal_timeline_id? Then it should be immediately clear what is meant here. Please, add this new field also to the CRD manifest (and chart). The field has to documented as well.

[FxKu]

type should be integer

[Sudeepta92]

Actually the timeline can be characters like A, B etc.. for eg C here: base_0000000C00000001000000A3

[FxKu]

But this is not the timeline ID

[thedatabaseme]

@Sudeepta92 FxKu is right here. The actual ID can only be an integer. What you see in the WAL archive name is a hex value. So for instance 0000003400000000000000CD would be timeline_id 52. Nevertheless, one can also specify latest or current in the recovery.conf. Which is default if nothing is set.
So I think, you could use and int32 here.

[Sudeepta92]

Oh yeahh its a hex value in the end. I will change to int32.

[Sudeepta92]

@FxKu @thedatabaseme btw, on changing type to integer back from string it fails when no timeline id is passed as it can no longer receive "latest"/"current".

[Sudeepta92]

Ok, so have removed the possibility for string value "latest" and in such a scenario it will calcuate the latest timeline id as integer. You may ignore my previous comment.

[Sudeepta92]

I think, we should not use the same name as the Spilo environment variable. We have also omitted the clone_ prefix from other variables. How about wal_timeline_id? Then it should be immediately clear what is meant here. Please, add this new field also to the CRD manifest (and chart). The field has to documented as well.

The parameter name has been changed to "wal_timeline_id" from "clone_target_timeline". And I am working on the docs.

[FxKu]

move to next milestone, because Spilo PR is still open